dataclients/kubernetes: refactor GetEndpointAddresses test #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestGetEndpointAddresses was broken because it used shared TestAPI instance and did not re-initialize it for each test. In partucular "Ingress with endpointslices" was actually testing endpoints and not endpointslices (testAPI.ServeHTTP does not even serve endpointslices). This change refactors GetEndpointAddresses test using kubernetestest.NewAPI and existing fixture files. For #2476 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
|
👍 |
1 similar comment
|
👍 |
AlexanderYastrebov
deleted the
dataclients/kubernetes/refactor-TestGetEndpointAddresses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestGetEndpointAddresses was broken because it used shared TestAPI instance and did not re-initialize it for each test.
In partucular "Ingress with endpointslices" was actually testing endpoints and not endpointslices (testAPI.ServeHTTP does not even serve endpointslices).
This change refactors GetEndpointAddresses test
using kubernetestest.NewAPI and existing fixture files.
For #2476