Generate decision ID using flowid generator #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pushpalanka
force-pushed
the
uuid
branch
3 times, most recently
from
6b2d670
to
d23a07f
Compare
Signed-off-by: Pushpalanka Jayawardhana <pushpalanka.jayawardhana@zalando.de>
…logic. Signed-off-by: Pushpalanka Jayawardhana <pushpalanka.jayawardhana@zalando.de>
AlexanderYastrebov
added
optimization
minor
Signed-off-by: Pushpalanka Jayawardhana <pushpalanka.jayawardhana@zalando.de>
Signed-off-by: Pushpalanka Jayawardhana <pushpalanka.jayawardhana@zalando.de>
|
I think we'll update dependencies
dependencies
|
|
👍 |
1 similar comment
|
👍 |
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the results of the benchmark tests added in #2896, it was noticed UUID generation for OPA decision ID is consuming a considerable fraction(17.8%) of evaluation time as below.
This PR makes use of existing flowID generator for decisionID generation, avoiding a syscall for UUID generation. The modification results in below graph where UUID generation is not prominent and overall evaluation time is reduce from 18.1% to 2.9%
Makes use of open-policy-agent/opa-envoy-plugin#516 released with 0.62.0-envoy version.
cc: @mjungsbluth