Merged
Conversation
ruudk
force-pushed
the
fix-github-actions
branch
from
fdaa9ed to
fd1ee9e
Compare
Contributor
Author
|
|
ruudk
force-pushed
the
fix-github-actions
branch
from
fd1ee9e to
3d952b2
Compare
aryszka
reviewed
Apr 5, 2020
Contributor
|
I am fine with addressing publish-coverage in a separate step |
Contributor
Author
|
What’s the goal of the publish coverage? Should it only run on the last tagged release? Or can we just run it on master, kind of the same right? |
Contributor
|
The "goal" goal of the publish_coverage is to motivate us to improve the actual test coverage by showing an approximation ;) for real, its goal is to show the test coverage of the master branch. So it's enough to run it after changes were pushed to master. But we don't want to make it a condition of the PRs. |
Contributor
|
👍 |
Contributor
Author
|
Oke then I understand it correctly, will update the PR and try to make it green ;-) |
ruudk
force-pushed
the
fix-github-actions
branch
6 times, most recently
from
244b585 to
7293e90
Compare
Signed-off-by: Ruud Kamphuis <ruudk@users.noreply.github.com>
Signed-off-by: Ruud Kamphuis <ruudk@users.noreply.github.com>
ruudk
force-pushed
the
fix-github-actions
branch
from
7293e90 to
e07335d
Compare
Contributor
Author
Contributor
|
👍 |
Contributor
Author
|
Please merge this and make these required checks:
|
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.