Skip to content

Commit

Permalink
fix typos, remove duplicated docs and link instead
Browse files Browse the repository at this point in the history
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
  • Loading branch information
szuecs committed May 2, 2019
1 parent da95088 commit c523550
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 20 deletions.
5 changes: 3 additions & 2 deletions docs/operation/operation.md
Original file line number Diff line number Diff line change
Expand Up @@ -561,13 +561,14 @@ Skipper has two filters [`lifo()`](../../reference/filters/#lifo) and
the number of requests for a route. A [documented load
test](https://github.com/zalando/skipper/pull/1030#issuecomment-485714338)
shows the behavior with an enabled `lifo(100,100,"10s")` filter for
all routes, that was added by default the filter flag:
all routes, that was added by default. You can do this, if you pass
the following flag to skipper:
`-default-filters-prepend=lifo(100,100,"10s")`.

Both LIFO filters will, use a last in first out queue to handle most
requests fast. If skipper is in an overrun mode, it will serve some
requests fast and some will timeout. The idea is based on Dropbox
bandit proxy, which is not opensource. [Dropbox](https://dropbox.com/)
bandaid proxy, which is not opensource. [Dropbox](https://dropbox.com/)
shared their idea in a [public
blogpost](https://blogs.dropbox.com/tech/2018/03/meet-bandaid-the-dropbox-service-proxy/).

Expand Down
16 changes: 2 additions & 14 deletions docs/reference/filters.md
Original file line number Diff line number Diff line change
Expand Up @@ -1400,7 +1400,7 @@ first out queue (LIFO), instead of an unbounded first in first out
queue (FIFO). The default skipper scheduler is based on Go net/http
package, which provides an unbounded FIFO request handling. If you
enable this filter the request scheduling will change to a LIFO. The
idea of a LIFO queue is based on Dropbox bandit proxy, which is not
idea of a LIFO queue is based on Dropbox bandaid proxy, which is not
opensource. Dropbox shared their idea in a
[public blogpost](https://blogs.dropbox.com/tech/2018/03/meet-bandaid-the-dropbox-service-proxy/).
All bounded scheduler filters will respond requests with server status error
Expand All @@ -1426,19 +1426,7 @@ to 150 and Timeout to 10 seconds.
## lifoGroup
Filter changes skipper to handle the route with a bounded last in
first out queue (LIFO), instead of an unbounded first in first out
queue (FIFO). The default skipper scheduler is based on Go net/http
package, which provides an unbounded FIFO request handling. If you
enable this filter the request scheduling will change to a LIFO. The
idea of a LIFO queue is based on Dropbox bandit proxy, which is not
opensource. Dropbox shared their idea in a
[public blogpost](https://blogs.dropbox.com/tech/2018/03/meet-bandaid-the-dropbox-service-proxy/).
All bounded scheduler filters will respond requests with server status error
codes in case of overrun. All scheduler filters return HTTP status code:
- 502, if the specified timeout is reached, because a request could not be scheduled fast enough
- 503, if the queue is full
This filter is similar to the [lifo](#lifo) filter.
Parameters:
Expand Down
2 changes: 1 addition & 1 deletion filters/builtin/redirect.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ type redirect struct {
// Name: "redirect".
//
// This filter is deprecated, use RedirectTo instead.
// This deprecated filter can not be used with filters from scheduler package.
// This *DEPRECATED* filter can not be used with filters from scheduler package.
func NewRedirect() filters.Spec { return &redirect{typ: redDeprecated} }

// NewRedirectTo returns a new filter Spec, whose instances create an HTTP redirect
Expand Down
2 changes: 1 addition & 1 deletion filters/scheduler/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// queue, the lifo and lifoGroup filter. Both lifo filters will, use a
// last in first out queue to handle most requests fast and if skipper
// is in an overrun mode, it will serve some requests fast and some
// will timeout. The idea is based on Dropbox bandit proxy, which is
// will timeout. The idea is based on Dropbox bandaid proxy, which is
// not opensource. Dropbox shared their idea in a public blogpost
// https://blogs.dropbox.com/tech/2018/03/meet-bandaid-the-dropbox-service-proxy/.
// This scheduler implementation makes sure that one route will not
Expand Down
2 changes: 0 additions & 2 deletions scheduler/scheduler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,7 @@ func TestScheduler(t *testing.T) {
}
}

// tt.paths
stacksMap := make(map[string][]*scheduler.Stack)

for _, group := range tt.paths {
key := group[0]

Expand Down

0 comments on commit c523550

Please sign in to comment.