Repository navigation
Conversation
Apply about:blank defaulting only to type so null instances remain null and explicit about:blank instances survive serialization. Signed-off-by: PHJ2000 <105151063+PHJ2000@users.noreply.github.com>
PHJ2000
requested review from
fatroom and
lukasniemeier-zalando
as code owners
October 5, 2026 03:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use Gson's URI adapter for instance and retain the existing type-specific adapter for type. This preserves null instances and explicitly supplied about:blank instances.
Motivation and Context
The shared adapter currently turns null instances into about:blank on reading and drops about:blank instances on writing. The null case also occurs when round-tripping a normal problem with serializeNulls().
Fixes #563.
Validation: four regression tests added (three fail before the fix); mvn -B -ntp clean verify passes all 123 tests on Java 21. DefaultProblemAdapter has 100% line and branch coverage.
Types of changes
Checklist: