Use scram-sha-256 hash if postgresql parameter password_encryption set to do so. #995
Conversation
yanchenko-igor
requested review from
avaczi,
CyberDem0n,
erthalion,
FxKu,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
yanchenko-igor
force-pushed
the
scram-sha-256_hash
branch
from
9da0744
to
a1c2ac2
Compare
yanchenko-igor
force-pushed
the
scram-sha-256_hash
branch
2 times, most recently
from
6d9f180
to
4f30903
Compare
|
Is anything wrong about this PR? our goal is to disable md5 in favor of scram-sha256, we could provide already encrypted passwor, but we would need postgres-operator to ignore password strings which start with "SCRAM-SHA-256$", could we do at least that? |
|
@yanchenko-igor can you rebase? I see some unrelevant changes here. In general, we nothing against this PR and would merge it soon. 😃 |
yanchenko-igor
force-pushed
the
scram-sha-256_hash
branch
2 times, most recently
from
ca4e500
to
a591ab6
Compare
@FxKu i rebased, the only irrelevant change is to travis config, without this change goveralls ignores some tests and doesn't show coverage of the new code, let me know if you would prefer to fix it in a separate PR. |
|
@yanchenko-igor yes can you move this part to a separate PR? Aside from that the PR looks fine. |
yanchenko-igor
force-pushed
the
scram-sha-256_hash
branch
from
a591ab6
to
d28ff70
Compare
|
All right, I removed the commit with travis settings, as expected, the coverage test didn't pass. Here is the change which will increase the coverage #1055 . |
yanchenko-igor
force-pushed
the
scram-sha-256_hash
branch
from
d28ff70
to
99a2c43
Compare
|
now it passes the coverage test 🎉 |
|
👍 |
1 similar comment
|
👍 |
Implemented scram-sha-256 to encrypt the password.