Added possibility to add custom annotations to LoadBalancer service. #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermajn
requested review from
alexeyklyukin,
avaczi,
CyberDem0n,
erthalion,
Jan-M and
sdudoladov
as code owners
sdudoladov
reviewed
Jan 23, 2019
| * **custom_service_annotations** | ||
| when load balancing is enabled, LoadBalancer service is created and | ||
| this parameter takes service annotations that are applied to service. | ||
| Optional. |
There was a problem hiding this comment.
is this applied to both replica and master LBs if they are enabled ?
There was a problem hiding this comment.
yes, that is correct, to both replica and master, but only LB type.
| @@ -1093,6 +1093,13 @@ func (c *Cluster) generateService(role PostgresRole, spec *acidv1.PostgresSpec) | |||
| constants.ZalandoDNSNameAnnotation: dnsName, | |||
| constants.ElbTimeoutAnnotationName: constants.ElbTimeoutAnnotationValue, | |||
| } | |||
|
|
|||
| if len(c.OpConfig.CustomServiceAnnotations) != 0 { | |||
| c.logger.Debugf("There are custom annotations defined, creating them.") | |||
There was a problem hiding this comment.
should not these annotations be applied only when the service of type LB is created ?
There was a problem hiding this comment.
yes, and considering line 1090 annotations are applied only in case of LB type.
sdudoladov
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadBalancer services in bare metal configuration usually requires some annotations to overcome problem assigning external IP. This should help with that.