Skip to content

Add logical backup #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 63 commits into from
May 16, 2019
Merged

Add logical backup #442

merged 63 commits into from
May 16, 2019

Conversation

sdudoladov
Copy link
Member

@sdudoladov sdudoladov commented Jan 8, 2019

Add logical backup by managing k8s cron jobs.

Jan-M
The operator will just manage another resource, which is a k8s cron job and sync it with the configuration. Kubernetes takes over the handling/spawning/retry, and e.g. monitoring will have to be solved somewhere else.

@Jan-M
Copy link
Member

Jan-M commented Jan 9, 2019

Can we rephrase this a bit in the description. The operator is def. not responsible for spawning anything.

The operator will just manage another resource, which is a k8s cron job and sync it with the configuration. Kubernetes takes over the handling/spawning/retry, and e.g. monitoring will have to be solved somewhere else.

@Jan-M
Copy link
Member

Jan-M commented Jan 9, 2019

Please also make exposed keys in the Postgres manifest consistent.

we use enableMasterLoadbalancer vs enable_logical_backup.

So let's stick to capitalization.

@sdudoladov
Copy link
Member Author

So let's stick to capitalization.

sure, just mixed it with the Patroni params in the complete manifest

@coveralls
Copy link

coveralls commented Jan 11, 2019

Coverage Status

Coverage remained the same at 23.766% when pulling 11019f5 on add-logical-backup into c70905a on master.

@sdudoladov
Copy link
Member Author

👍

@@ -91,4 +91,7 @@ configuration:
# scalyr_api_key: ""
# scalyr_image: ""
# scalyr_server_url: ""

logical_backup_key:
Copy link
Member

@FxKu FxKu May 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it called "_key"? I'm missing the enable_logical_backup flag here. Same for configMap

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it called "_key"?

by mistake, will fix

I'm missing the enable_logical_backup flag here. Same for configMap

There is no such key, because that particular feature is supposed to be triggered by users only on very few selected PG clusters ; it hardly makes sense to enable it for all DBs within a k8s cluster.

@FxKu
Copy link
Member

FxKu commented May 16, 2019

👍

1 similar comment
@sdudoladov
Copy link
Member Author

👍

@sdudoladov sdudoladov merged commit f3e1e80 into master May 16, 2019
@FxKu FxKu added this to the v1.2 milestone May 20, 2019
@FxKu FxKu mentioned this pull request May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants