-
Notifications
You must be signed in to change notification settings - Fork 1k
Add logical backup #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logical backup #442
Conversation
Can we rephrase this a bit in the description. The operator is def. not responsible for spawning anything. The operator will just manage another resource, which is a k8s cron job and sync it with the configuration. Kubernetes takes over the handling/spawning/retry, and e.g. monitoring will have to be solved somewhere else. |
Please also make exposed keys in the Postgres manifest consistent. we use enableMasterLoadbalancer vs enable_logical_backup. So let's stick to capitalization. |
sure, just mixed it with the Patroni params in the complete manifest |
👍 |
@@ -91,4 +91,7 @@ configuration: | |||
# scalyr_api_key: "" | |||
# scalyr_image: "" | |||
# scalyr_server_url: "" | |||
|
|||
logical_backup_key: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it called "_key"? I'm missing the enable_logical_backup flag here. Same for configMap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it called "_key"?
by mistake, will fix
I'm missing the enable_logical_backup flag here. Same for configMap
There is no such key, because that particular feature is supposed to be triggered by users only on very few selected PG clusters ; it hardly makes sense to enable it for all DBs within a k8s cluster.
👍 |
1 similar comment
👍 |
Add logical backup by managing k8s cron jobs.