[WIP] Add 'admin' option to create role #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdudoladov
requested review from
alexeyklyukin,
avaczi,
CyberDem0n,
erthalion and
Jan-M
as code owners
Jan-M
previously approved these changes
Dec 3, 2018
|
I am fine with this, but slight objection to the config variable name. Not sure we need the word "robot". This word is not clearly defined, it is simply "users" from the manifest. |
Jan-M
reviewed
Dec 3, 2018
| @@ -365,6 +365,9 @@ key. | |||
| role name to grant to team members created from the Teams API. The default is | |||
| `admin`, that role is created by Spilo as a `NOLOGIN` role. | |||
|
|
|||
| * **add_admin_flag_to_robot_roles** | |||
There was a problem hiding this comment.
enable_admin_role_for_users
Could be good enough, the others are "admin/superusers" and "team members" so maybe "users" is good enough.
There was a problem hiding this comment.
Agree, robot is too specific here.
|
Can the last comment be adressed, so we can close this? |
erthalion
approved these changes
Dec 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #424