reflect linter feedback, remove unused arguments and redundant type from arrays #2739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
Jan-M,
hughcapet,
idanovinda,
jopadi,
macedigital and
sdudoladov
as code owners
Member
Author
|
👍 |
macedigital
reviewed
Aug 27, 2024
| } else { | ||
| c.logger.Infof("customResourceDefinition %q has been registered", crd.Name) | ||
| } | ||
| c.logger.Infof("customResourceDefinition %q is registered", crd.Name) |
Member
There was a problem hiding this comment.
Curious if this logs nil in some edge cases.
macedigital
approved these changes
Aug 27, 2024
Member
macedigital
left a comment
macedigital
left a comment
There was a problem hiding this comment.
Looks good to me.
go-staticcheck highlights a few more cases, but we can fix those later 1.
Footnotes
-
Example without arguments to formatter https://github.com/zalando/postgres-operator/blob/a6c40dad785a229b5e69b0de757f2158c80bd10b/pkg/cluster/util.go#L260 ↩
FxKu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The amount of problems reported by the linter - mainly redundant type declarations - made it hard to see problems such as nil references and unused variables. With this PR merged no more problems should be reported - at least in VSCode