Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sync streams and add diffs for annotations and owner references #2728

Merged
merged 4 commits into from
Aug 14, 2024
Merged

fix sync streams and add diffs for annotations and owner references #2728

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4f00b7
extend and improve hasSlotsInSync unit test
FxKu Aug 13, 2024
612fe5a
fix sync streams and add diffs for annotations and owner references
FxKu Aug 14, 2024
a710130
incl. current annotations as desired where we do not fully control them
FxKu Aug 14, 2024
8b919d8
added one more unit test and fixed sub test names
FxKu Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
added one more unit test and fixed sub test names
  • Loading branch information
@FxKu
FxKu committed Aug 14, 2024
commit 8b919d8db776b5e76c6504ada76f55fb4bddeaff
31 changes: 27 additions & 4 deletions pkg/cluster/streams_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ func TestHasSlotsInSync(t *testing.T) {
},
slotsInSync: true,
}, {
subTest: fmt.Sprintf("slots empty for applicationId %s", appId),
subTest: fmt.Sprintf("slots empty for applicationId %s after create or update of publication failed", appId),
applicationId: appId,
expectedSlots: map[string]map[string]zalandov1.Slot{
dbNotExists: {
Expand All @@ -272,7 +272,30 @@ func TestHasSlotsInSync(t *testing.T) {
actualSlots: map[string]map[string]string{},
slotsInSync: false,
}, {
subTest: fmt.Sprintf("one slot not in sync for applicationId %s", appId),
subTest: fmt.Sprintf("slot with empty definition for applicationId %s after publication git deleted", appId),
applicationId: appId,
expectedSlots: map[string]map[string]zalandov1.Slot{
dbNotExists: {
slotNotExists: zalandov1.Slot{
Slot: map[string]string{
"databases": dbName,
"plugin": constants.EventStreamSourcePluginType,
"type": "logical",
},
Publication: map[string]acidv1.StreamTable{
"test1": acidv1.StreamTable{
EventType: "stream-type-a",
},
},
},
},
},
actualSlots: map[string]map[string]string{
slotName: nil,
},
slotsInSync: false,
}, {
subTest: fmt.Sprintf("one slot not in sync for applicationId %s because database does not exist", appId),
applicationId: appId,
expectedSlots: map[string]map[string]zalandov1.Slot{
dbName: {
Expand Down Expand Up @@ -313,7 +336,7 @@ func TestHasSlotsInSync(t *testing.T) {
},
slotsInSync: false,
}, {
subTest: fmt.Sprintf("slots in sync for applicationId %s, but not for for %s - checking %s", appId, appId2, appId),
subTest: fmt.Sprintf("slots in sync for applicationId %s, but not for %s - checking %s should return true", appId, appId2, appId),
applicationId: appId,
expectedSlots: map[string]map[string]zalandov1.Slot{
dbName: {
Expand Down Expand Up @@ -354,7 +377,7 @@ func TestHasSlotsInSync(t *testing.T) {
},
slotsInSync: true,
}, {
subTest: fmt.Sprintf("slots in sync for applicationId %s, but not for for %s - checking %s", appId, appId2, appId2),
subTest: fmt.Sprintf("slots in sync for applicationId %s, but not for %s - checking %s should return false", appId, appId2, appId2),
applicationId: appId2,
expectedSlots: map[string]map[string]zalandov1.Slot{
dbName: {
Expand Down
Loading