Fix updating SynchronousNodeCount (#2552) #2558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRD support for synchronous_node_count was previously added in zalando#1484, however the desired SynchronousNodeCount was not compared to the actual patroni configuration, which meant it was never updated.
cstohr1
requested review from
FxKu,
Jan-M,
hughcapet,
idanovinda,
jopadi,
macedigital and
sdudoladov
as code owners
Member
|
👍 |
1 similar comment
Member
|
👍 |
Member
|
@cstohr1 thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRD support was added previously, but comparing desired SynchronousNodeCount to the actual patroni config was missing