Add service account name in connection pooler #2352
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdmikechen
requested review from
FxKu,
Jan-M,
hughcapet,
idanovinda,
jopadi and
sdudoladov
as code owners
Member
|
Thanks @cdmikechen . Ideally we would need a service account and role specifically for the pooler, although it does not need any resource privileges. I think for now postgres-pod might be fine as it's not all too powerful. |
Member
|
👍 |
1 similar comment
Member
|
👍 |
Merged
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on PR #2255
Setting runAsUser directly is not allowed on, for example, Openshift.
So we should change the serviceaccount of the pooler to
postgres-podas well, otherwise the pooler will not be created correctly.