better backwards compatibility with old DNS name format for LBs #2171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
Jan-M,
hughcapet,
idanovinda,
jopadi and
sdudoladov
as code owners
Member
|
👍 |
Member
Author
|
👍 |
1 similar comment
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #2011 we changed the default DNS name format template used when LoadBalancers are enabled. For backwards compatibility we are already appending a second DNS entry when the cluster name still starts with the team Id (mandatory before #2001), because we do not want to break existing connections.
For the old format we only assumed the default template value
"{cluster}.{team}.{hostedzone}". There's no option to specify what you have used before. If you have customized the template, all apps would need to be redeployed using the new DNS format. To avoid such a hassle this PR suggest to make the old format configurable withmaster|replica_old_dns_name_formatoptions.The unit test in cluster_test_go has be updated to also use a template different from the default value.