Skip to content

Integrate in CI and align with the golangci-lint default rules #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dmvolod wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Integrate in CI and align with the golangci-lint default rules #2135

dmvolod wants to merge 16 commits into from

Conversation

@dmvolod
Copy link
Contributor

@dmvolod dmvolod commented Dec 11, 2022 •
edited
Loading

Closes #1785

Some additional fixes

  • unit tests step removed from the e2e job (already part of the unit tests workflow and running twice)
  • make verify-codegen step added to the unit test stage
  • most of the actions version updated to the latest release
  • go version stabilized (some CI actions utilized 1.19 unfortunately instead of required 1.18.x) but not utilizing golang version cache

TODO

  • Separate tools installation and Makefile targets
  • Install tools to the local folder instead for common GOPATH/bin to avoid confusion

@dmvolod dmvolod marked this pull request as ready for review December 12, 2022 11:32
@FxKu FxKu added this to the 2.0 milestone Dec 14, 2022
@dmvolod dmvolod mentioned this pull request Jan 11, 2023
Merged
@dmvolod dmvolod force-pushed the issue-1785 branch 2 times, most recently from 6d66e33 to e003a0a Compare January 17, 2023 14:37
@dmvolod dmvolod mentioned this pull request Mar 25, 2023
Merged
@FxKu FxKu modified the milestones: 1.11.0, 2.0 Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@FxKu FxKu Awaiting requested review from FxKu FxKu is a code owner

@jopadi jopadi Awaiting requested review from jopadi jopadi is a code owner

@idanovinda idanovinda Awaiting requested review from idanovinda idanovinda is a code owner

@hughcapet hughcapet Awaiting requested review from hughcapet hughcapet is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Postgres Operator
Status: Waiting for review

Milestone

wishlist

Development

Successfully merging this pull request may close these issues.

Integrate in CI and align with the golangci-lint rules

2 participants

@dmvolod @FxKu