Skip to content

add build arm image pipeline #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

add build arm image pipeline #2127

wants to merge 1 commit into from

Conversation

@lengrongfu
Copy link

@lengrongfu lengrongfu commented Dec 6, 2022

issue: #2122

@lengrongfu lengrongfu force-pushed the master branch 2 times, most recently from 31b9a92 to 83ae12f Compare December 8, 2022 08:32
@lengrongfu
Copy link
Author

lengrongfu commented Dec 21, 2022

@FxKu Hi, PTAL.

hughcapet
hughcapet reviewed Dec 21, 2022
View reviewed changes
@FxKu FxKu modified the milestones: 1.9, 2.0 Jan 10, 2023
verbotenj
verbotenj reviewed Feb 13, 2023
View reviewed changes
verbotenj
verbotenj reviewed Feb 13, 2023
View reviewed changes
verbotenj
verbotenj reviewed Feb 13, 2023
View reviewed changes
docker/Dockerfile-multi-arch
@@ -0,0 +1,23 @@
FROM golang:1.18.3 as build
Copy link

@verbotenj verbotenj Feb 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move the code that you added into existing Dockerfile

verbotenj
verbotenj reviewed Feb 14, 2023
View reviewed changes
verbotenj
verbotenj reviewed Feb 14, 2023
View reviewed changes
verbotenj
verbotenj reviewed Feb 15, 2023
View reviewed changes
@verbotenj
Copy link

verbotenj commented Feb 23, 2023

@lengrongfu @FxKu PTAL

@mprimeaux
Copy link

mprimeaux commented Mar 3, 2023

Just checking to see if I can help in any way to support this merge. Much thanks in advance.

verbotenj
verbotenj reviewed Mar 15, 2023
View reviewed changes
verbotenj
verbotenj reviewed Mar 15, 2023
View reviewed changes
@lengrongfu
add build arm image
f498b20 
Signed-off-by: lengrongfu <1275177125@qq.com>
@verbotenj
Copy link

verbotenj commented Mar 29, 2023

Another thing to consider is that in the operator helm chart, there are multiple images that can be specified.
Example: https://github.com/zalando/postgres-operator/blob/master/charts/postgres-operator/values.yaml#L351
Dockerfile for it
https://github.com/zalando/postgres-operator/blob/master/docker/logical-backup/Dockerfile
To have everything running only on arm64 arch.

@jonizen jonizen mentioned this pull request May 20, 2023
Closed
@FxKu
Copy link
Member

FxKu commented Jan 23, 2024

Closed in favor for #2268. Thanks again to all contributors.

@FxKu FxKu closed this Jan 23, 2024
@FxKu FxKu modified the milestones: 1.11.0, 1.10.0 Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hughcapet hughcapet hughcapet left review comments

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@FxKu FxKu Awaiting requested review from FxKu FxKu is a code owner

@jopadi jopadi Awaiting requested review from jopadi jopadi is a code owner

@idanovinda idanovinda Awaiting requested review from idanovinda idanovinda is a code owner

+1 more reviewer

@verbotenj verbotenj verbotenj left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lengrongfu @verbotenj @mprimeaux @FxKu @hughcapet