fetch pooler and fes_user system user only when corresponding features are used #2009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…responding features are used
FxKu
requested review from
CyberDem0n,
Jan-M,
idanovinda,
jopadi and
sdudoladov
as code owners
FxKu
changed the title
Member
|
👍 |
1 similar comment
Member
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If somebody unintentionally defines reserved system users
poolerorfes_userin the manifest, the updateSecret function will use the systemUsers map. But if the pooler or stream feature are not used, no corresponding PgUser object will exist in that map. The PgUser used in password rotation will be empty ultimatly leading to this error:The bug was introduced with #1953 .