Fix for AllowPrivilegeEscalation : issue-1403

[neelasha-09]

Fix for #1403

[neelasha-09]

@FxKu @sdudoladov - This is the fix for the bug introduced in OPR 1.6 that does not allow cron to work any longer.
A quick review would be highly appreciated. We tested and everything is working fine again with no errors.
Spilo Issue: zalando/spilo#562 which we reviewed with @CyberDem0n

[FxKu]

Thanks for your contribution @neelasha-09 . Looks good. The name for the parameter is fine. Two minor things.

1. In yaml manifests I'd like to keep alphabetical sorting so move spilo_allow_privilege_escalation further up.
2. I'm thinking if the default should be false, too, like with privileged mode. OTOH looking at the use cases you've mentioned (cron, cert rotation) it seems to be more user-friendly if it's set to true straight away. Other opinions?

[neelasha-09]

Thanks for your contribution @neelasha-09 . Looks good. The name for the parameter is fine. Two minor things.

1. In yaml manifests I'd like to keep alphabetical sorting so move spilo_allow_privilege_escalation further up.

         We thought of keeping the `spilo_allow_privilege_escalation` and `spilo_privileged`  
         next to each other as they are closely related.

2. I'm thinking if the default should be false, too, like with privileged mode. OTOH looking at the use cases you've mentioned (cron, cert rotation) it seems to be more user-friendly if it's set to true straight away. Other opinions?

         The default value to `false` would cause BWC with OPR  version1.5.0. 
         Without this parameter, functionality would be decreased. 
         In our opinion, it should not be postponed  till next milestone  & rather consider as fix within same release.

[FxKu]

1. Makes sense, but would also apply to many other existing options. Alphabetical sorting makes it easier in the end to find stuff. And with the spilo_ prefix the options are not that far away from each other anyway.
2. Good point keeping it consistent with 1.5.0.

[neelasha-09]

1. Makes sense, but would also apply to many other existing options. Alphabetical sorting makes it easier in the end to find stuff. And with the spilo_ prefix the options are not that far away from each other anyway.

             Sorted the parameters in alphabetical order as suggested. 

2. Good point keeping it consistent with 1.5.0.

             Also, could you please consider of not postponing the fix until 1.7.0  and fix is within the same release

[FxKu]

👍

[sdudoladov]

👍

[FxKu]

Thanks @neelasha-09 . We are making it a 1.6.2 release now. We cannot replace previous images/releases.

[neelasha-09]

Thanks @FxKu for the PR merge
However, I've raised another PR with the correction in the default values for the parameter SpiloAllowPrivilegeEscalation under pkg/util/config/config.go - #1434