Use fake client for connection pooler #1301
Conversation
RafiaSabih
requested review from
CyberDem0n,
FxKu,
Jan-M,
avaczi,
erthalion and
sdudoladov
as code owners
|
Docker image "registry-write.opensource.zalan.do/acid/postgres-operator-ui-test:4e8acc2-pr-1301-1" is not based on an approved base image. Currently, this will have no impact on your deployments, but builds using non-allowed images will be blocked from deployment from February 1st 2021. To create a compliant Docker image of your application, you must reference an allowed Docker image as its base image in your Dockerfile. This base image must come from the Open Source Registry namespace |
|
Docker image "registry-write.opensource.zalan.do/acid/postgres-operator-ui-test:c666e2a-pr-1301-2" is not based on an approved base image. Currently, this will have no impact on your deployments, but builds using non-allowed images will be blocked from deployment from February 1st 2021. To create a compliant Docker image of your application, you must reference an allowed Docker image as its base image in your Dockerfile. This base image must come from the Open Source Registry namespace |
|
was their a discussion to put it in an extra file an not add it to |
|
Docker image "registry-write.opensource.zalan.do/acid/postgres-operator-ui-test:ce2b791-pr-1301-3" is not based on an approved base image. Currently, this will have no impact on your deployments, but builds using non-allowed images will be blocked from deployment from February 1st 2021. To create a compliant Docker image of your application, you must reference an allowed Docker image as its base image in your Dockerfile. This base image must come from the Open Source Registry namespace |
|
Docker image "registry-write.opensource.zalan.do/acid/postgres-operator-test:v1.6.0-15-g4c615aa-pr-1301-5" is not based on an approved base image. Currently, this will have no impact on your deployments, but builds using non-allowed images will be blocked from deployment from February 1st 2021. To create a compliant Docker image of your application, you must reference an allowed Docker image as its base image in your Dockerfile. This base image must come from the Open Source Registry namespace |
|
Docker image "registry-write.opensource.zalan.do/acid/postgres-operator-ui-test:v1.6.0-15-g425336e-pr-1301-5" is not based on an approved base image. Currently, this will have no impact on your deployments, but builds using non-allowed images will be blocked from deployment from February 1st 2021. To create a compliant Docker image of your application, you must reference an allowed Docker image as its base image in your Dockerfile. This base image must come from the Open Source Registry namespace |
|
Docker image "registry-write.opensource.zalan.do/acid/postgres-operator-test:v1.6.0-16-gc174de7-pr-1301-6" is not based on an approved base image. Currently, this will have no impact on your deployments, but builds using non-allowed images will be blocked from deployment from February 1st 2021. To create a compliant Docker image of your application, you must reference an allowed Docker image as its base image in your Dockerfile. This base image must come from the Open Source Registry namespace |
| if err != nil { | ||
| t.Errorf("%s: Cannot create connection pooler, %s, %+v", | ||
| testName, err, reason) | ||
| func MasterobjectsAreSaved(cluster *Cluster, err error, reason SyncReason) error { |
There was a problem hiding this comment.
small thing: MasterObjects (o -> O)
| return nil | ||
| } | ||
|
|
||
| func ReplicaobjectsAreSaved(cluster *Cluster, err error, reason SyncReason) error { |
There was a problem hiding this comment.
again ReplicaObjects (o -> O)
| ConnectionPoolerDefaultCPULimit: "100m", | ||
| ConnectionPoolerDefaultMemoryRequest: "100Mi", | ||
| ConnectionPoolerDefaultMemoryLimit: "100Mi", | ||
| NumberOfInstances: int32ToPointer(1), |
There was a problem hiding this comment.
Why int32ToPointer(1) instead of simply 1 ?
There was a problem hiding this comment.
because NumberOfInstances is of type *int32...!
|
👍 |
1 similar comment
|
👍 |
Test for creation and deletion of connection pooler, using k8s fake client API.