Support EBS gp2 to gp3 migration on sync for below 1tb volumes #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jan-M
requested review from
CyberDem0n,
FxKu,
RafiaSabih,
avaczi,
erthalion and
sdudoladov
as code owners
Jan-M
force-pushed
the
quick-gp3-support
branch
from
b1a8843 to
6bb78c8
Compare
Jan-M
changed the title
Member
Author
|
👍 |
FxKu
reviewed
Dec 10, 2020
FxKu
reviewed
Dec 10, 2020
| } | ||
| } | ||
|
|
||
| if c.OpConfig.StorageResizeMode == "mixed" { |
Member
There was a problem hiding this comment.
I fail to see the difference to c.OpConfig.StorageResizeMode == "pvc". If there is another case for StorageResizeMode, it should be documented.
Member
Author
There was a problem hiding this comment.
Future work, we need "mixed" to do call to EBS for volume changes and rely on PVC to do file system extension without privileged pods.
FxKu
reviewed
Dec 10, 2020
FxKu
reviewed
Dec 10, 2020
| } | ||
| } | ||
|
|
||
| func CreatePVCs(namespace string, clusterName string, labels labels.Set, n int, size string) v1.PersistentVolumeClaimList { |
Member
There was a problem hiding this comment.
we could reuse this for the already existing TestResizeVolumeClaim test
Member
|
I will add the new config fields to CRD validation and helm chart and update |
Member
Author
|
👍 |
1 similar comment
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support migration of existing gp2 volumes below a certain threshold to be migrated to gp3.