Changes to support separate bucket per pg cluster (#1209) #1239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Done
WAL_S3_BUCKET
used in pg configmap will result in the cluster using that bucket for streaming/pushing WAL archives. In case it's not set, the default bucketwal_s3_bucket
from operator configmap will be used. This bucket should be accessible by the userAWS_ACCESS_KEY_ID
in pg configmap.LOGICAL_BACKUP_S3_BUCKET
used in pg configmap will result in the cluster using that bucket for pushing logical backups. In case its not set, the default bucketlogical_backup_s3_bucket
from operator configmap will be used. This bucket should be accessible by the userlogical_backup_s3_access_key_id
in operator configmap. Using a custom user for a logical backup bucket is not included in this PR.Ideally, we will always use the same bucket for WAL and logical backups.
Tests performed
WAL_S3_BUCKET
orLOGICAL_BACKUP_S3_BUCKET
. Create primaryWAL_S3_BUCKET
orLOGICAL_BACKUP_S3_BUCKET
. Create standbyWAL_S3_BUCKET
andLOGICAL_BACKUP_S3_BUCKET
. Create primaryWAL_S3_BUCKET
andLOGICAL_BACKUP_S3_BUCKET
. Create standby to stream from default bucketWAL_S3_BUCKET
and don't setLOGICAL_BACKUP_S3_BUCKET
. Create primaryWAL_S3_BUCKET
andLOGICAL_BACKUP_S3_BUCKET
. Clone from custom bucket