Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding '_' to allowed chars. #115

Merged
merged 2 commits into from
Oct 5, 2017
Merged

Adding '_' to allowed chars. #115

merged 2 commits into from
Oct 5, 2017

Conversation

Jan-M
Copy link
Member

@Jan-M Jan-M commented Oct 5, 2017

Adding "_" to chars.

mkabilov
mkabilov reviewed Oct 5, 2017
View reviewed changes
pkg/cluster/cluster.go Outdated
@@ -31,6 +31,7 @@ import (

var (
alphaNumericRegexp = regexp.MustCompile("^[a-zA-Z][a-zA-Z0-9]*$")
databaseNameRegexp = regexp.MustCompile("^[a-zA-Z][a-zA-Z0-9_]*$")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postgres allows having database names starting with _

@mkabilov
Copy link
Contributor

mkabilov commented Oct 5, 2017

👍

1 similar comment
@Jan-M
Copy link
Member Author

Jan-M commented Oct 5, 2017

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 8.635% when pulling c4af0ac on database-name-fix into 48ec6b3 on master.

@Jan-M Jan-M merged commit bd9b0b6 into master Oct 5, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 8.635% when pulling c4af0ac on database-name-fix into 48ec6b3 on master.

@erthalion erthalion deleted the database-name-fix branch September 13, 2018 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkabilov mkabilov mkabilov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jan-M @mkabilov @coveralls