Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve e2e test debugging #1107

Merged
merged 5 commits into from
Aug 28, 2020
Merged

improve e2e test debugging #1107

merged 5 commits into from
Aug 28, 2020

Conversation

FxKu
Copy link
Member

@FxKu FxKu commented Aug 14, 2020

print operator log whenever we face a timeout in a test

@erthalion erthalion changed the title improve e2e test debiggung improve e2e test debugging Aug 14, 2020
Copy link
Member

@sdudoladov sdudoladov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. test_enable_load_balancer lacks the proposed change
  2. it should be possible to move the
try:
...
except timeout_decorator.TimeoutError:
            print('Operator log: {}'.format(k8s.get_operator_log()))
            raise

part into a decorator of its own. That approach would make code cleaner and easier to re-use.

  1. UPD please fix flake8 violations if any

@FxKu
Copy link
Member Author

FxKu commented Aug 28, 2020

👍

1 similar comment
@sdudoladov
Copy link
Member

👍

@sdudoladov sdudoladov merged commit 5e93aab into master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants