Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RemoteResponseTest #1436

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Fix RemoteResponseTest #1436

merged 1 commit into from
Feb 27, 2023

Conversation

ChristianLohmann
Copy link
Member

the statusCanThrow test method mocked a mock

Description

this PR fixes the test method and mocks a real ClientHttpResponse

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@DaniloVeljovic
Copy link
Member

👍🏼

@DaniloVeljovic DaniloVeljovic merged commit 1b00c7e into main Feb 27, 2023
@kasmarian kasmarian deleted the fix_remote_response_test branch April 6, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whiskeysierra whiskeysierra Awaiting requested review from whiskeysierra whiskeysierra is a code owner

@lukasniemeier-zalando lukasniemeier-zalando Awaiting requested review from lukasniemeier-zalando lukasniemeier-zalando is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristianLohmann @DaniloVeljovic