Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 17 compiler support while keeping source/target levels intact #1434

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Java 17 compiler support while keeping source/target levels intact #1434

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f27584b
Update compiler to java 17
sdousti Feb 24, 2023
5278e2d
Copy compiler settings to top-level
sdousti Feb 24, 2023
f95ec8e
Remove compiler settings from logbook-parent
sdousti Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update compiler to java 17
  • Loading branch information
@sdousti
sdousti committed Feb 24, 2023
commit f27584bf74ec2cc96288ef92d3eba90890103322
10 changes: 6 additions & 4 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,18 @@ jobs:
profile: ['']
steps:
- name: Checkout
uses: actions/checkout@v1
uses: actions/checkout@v3
- name: Cache
uses: actions/cache@v1
uses: actions/cache@v3
with:
path: ~/.m2
key: m2
- name: Set up JDK
uses: actions/setup-java@v1
uses: actions/setup-java@v3
with:
java-version: 1.8
distribution: temurin
java-version: 17
cache: 'maven'
- name: Compile
run: ./mvnw clean test-compile -B
- name: Test
Expand Down
8 changes: 4 additions & 4 deletions logbook-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<java.version>1.8</java.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
<java.version>17</java.version>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>

<jackson.version>2.14.2</jackson.version>
<json-path.version>2.7.0</json-path.version>
Expand Down Expand Up @@ -402,7 +402,7 @@
<artifactId>kotlin-maven-plugin</artifactId>
<version>${kotlin.version}</version>
<configuration>
<jvmTarget>${java.version}</jvmTarget>
<jvmTarget>${maven.compiler.target}</jvmTarget>
<args>
<arg>-Xopt-in=kotlin.RequiresOptIn</arg>
</args>
Expand Down