Preserve case of reason phrase from the actual server response #1320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some servers respond with an upper case reason phrase.
logbook-httpclient5 uses fixed reason phrase strings from
org.zalando.logbook.HttpResponse
.This PR makes it take the reason phrase from the actual server response instead.
Example:
A request to https://httpbin.org/status/400
will currently be logged like this by logbook:
This change will make it log like this instead:
I guess this can possibly be considered a breaking change.
Motivation and Context
I want the log to be as close to the actual server response as possible.
Types of changes
Checklist: