finally + test (#1668)

zalando · Nov 11, 2023 · 78d0cd2 · 78d0cd2
1 parent e81ca4a
commit 78d0cd2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/...k-spring/src/main/java/org/zalando/logbook/spring/BufferingClientHttpResponseWrapper.java b/...k-spring/src/main/java/org/zalando/logbook/spring/BufferingClientHttpResponseWrapper.java
@@ -47,8 +47,9 @@ public void close() {
             body.close();
         } catch (IOException e){
             throw new RuntimeException(e);
+        } finally {
+            delegate.close();
         }
-        delegate.close();
     }
 
     @Override

diff --git a/...ring/src/test/java/org/zalando/logbook/spring/BufferingClientHttpResponseWrapperTest.java b/...ring/src/test/java/org/zalando/logbook/spring/BufferingClientHttpResponseWrapperTest.java
@@ -84,6 +84,7 @@ void close_throws() throws IOException {
         doThrow(new IOException()).when(inputStream).close();
 
         assertThrows(RuntimeException.class, () -> wrapper.close());
+        verify(delegate).close();
     }
 
     @Test
-Original file line number
+Diff line change
@@ Expand Up / @@ -84,6 +84,7 @@ void close_throws() throws IOException { @@
             doThrow(new IOException()).when(inputStream).close();
             assertThrows(RuntimeException.class, () -> wrapper.close());
+            verify(delegate).close();
         }
         @Test
@@ Expand Down @@