-
Notifications
You must be signed in to change notification settings - Fork 11
#29 Nakadi SQL Query tab and server support added #30
Conversation
It will not be allowed to have 'any valid token' in admin section, maybe this can be a flag in the configuration? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall
OnInput | ||
"Output Event Type Name" | ||
"Example: bazar.price-updater.price_changed" | ||
"Should be several words (with '_', '-') separated by dot." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be one word too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no. I mean yes, but it is bad practice https://opensource.zalando.com/restful-api-guidelines/#223
OnInput | ||
"Owning Application" | ||
"Example: stups_price-updater" | ||
"App name registered in YourTurn with 'stups_' prefix" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the open source nakadi UI doesn't know what yourturn is :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but we don't have anything better for now.
cleanup from stups requires the additional ticket in the future. But I would keep it now for consistency reasons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
, newline | ||
, text "The SQL statements supported are a subset of ANSI SQL." | ||
, newline | ||
, text "The operations supported are joining two or more EventTypes and filtering" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And projection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just a copycat :) https://github.bus.zalan.do/aruha/nakadi-sql-api/blob/master/docs/_data/nakadi-sql-api-definition.yaml#L186
fix the source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do!
, text "The SQL statements supported are a subset of ANSI SQL." | ||
, newline | ||
, text "The operations supported are joining two or more EventTypes and filtering" | ||
, text " EventTypes to an output EventType. The EventTypes on which these queries are run MUST" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we are going to support filter and projection on all event types before going GA then open source. Joins are log-compacted only for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we will change it accordingly (maybe change will be bigger).
span | ||
[ onClick OpenDeleteQueryPopup | ||
, class "icon-link dc-icon--trash dc-btn--destroy dc-icon dc-icon--interactive" | ||
, title "Terminate Query" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer "Deactivate Query"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or "Stop Query"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I choose this word because there is no opposite word like "unterminate" in opposite to "Activate/Reactivate" and "Stop". To suggest people that they cannot restart it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point
[ text "Nakadi SQL API provides a self-serviceable SQL interface for stream processing Nakadi event" | ||
, text " types. By expressing transformations as SQL, this service enables a broader audience to analyse" | ||
, text " and process streaming data in real-time. Nakadi SQL is scalable, elastic and fault-tolerant." | ||
, text " It's planned to support a wide range of streaming operations, including data filtering," |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's
-> It is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but fix it in api.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
, text " types. By expressing transformations as SQL, this service enables a broader audience to analyse" | ||
, text " and process streaming data in real-time. Nakadi SQL is scalable, elastic and fault-tolerant." | ||
, text " It's planned to support a wide range of streaming operations, including data filtering," | ||
, text " transformations, aggregations, joins, windowing, and sessionization." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sessionization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither do I :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a thing apparently https://www.dataiku.com/learn/guide/code/reshaping_data/sessionization.html
, newline | ||
, text "The output events are written to an output EventType, which can be accessed via Nakadi." | ||
, newline | ||
, link "More in the API Manual" "https://apis.zalando.net/apis/3d932e38-b9db-42cf-84bb-0898a72895fb/ui" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't accessible for non-Zalandos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#29 Nakadi SQL Query tab and server support added