Skip to content
This repository has been archived by the owner on Jan 7, 2022. It is now read-only.

#29 Nakadi SQL Query tab and server support added #30

Merged
merged 19 commits into from
Nov 16, 2018
Merged

Conversation

SergKam
Copy link
Contributor

@SergKam SergKam commented Nov 3, 2018

#29 Nakadi SQL Query tab and server support added

  • Server config and endpoint
  • Server mock model
  • Client Query model
  • Query tab on Event Type details page added
    localhost_3000_
    localhost_3000_ 1

@SergKam SergKam added the WIP Wrok In Progress (someone already working on it) label Nov 3, 2018
@SergKam SergKam removed the WIP Wrok In Progress (someone already working on it) label Nov 12, 2018
@SergKam SergKam requested a review from lmontrieux November 12, 2018 01:30
@lmontrieux
Copy link
Contributor

It will not be allowed to have 'any valid token' in admin section, maybe this can be a flag in the configuration?

Copy link
Contributor

@lmontrieux lmontrieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall

OnInput
"Output Event Type Name"
"Example: bazar.price-updater.price_changed"
"Should be several words (with '_', '-') separated by dot."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be one word too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. I mean yes, but it is bad practice https://opensource.zalando.com/restful-api-guidelines/#223

OnInput
"Owning Application"
"Example: stups_price-updater"
"App name registered in YourTurn with 'stups_' prefix"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the open source nakadi UI doesn't know what yourturn is :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we don't have anything better for now.
cleanup from stups requires the additional ticket in the future. But I would keep it now for consistency reasons.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

, newline
, text "The SQL statements supported are a subset of ANSI SQL."
, newline
, text "The operations supported are joining two or more EventTypes and filtering"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And projection

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do!

, text "The SQL statements supported are a subset of ANSI SQL."
, newline
, text "The operations supported are joining two or more EventTypes and filtering"
, text " EventTypes to an output EventType. The EventTypes on which these queries are run MUST"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we are going to support filter and projection on all event types before going GA then open source. Joins are log-compacted only for now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we will change it accordingly (maybe change will be bigger).

span
[ onClick OpenDeleteQueryPopup
, class "icon-link dc-icon--trash dc-btn--destroy dc-icon dc-icon--interactive"
, title "Terminate Query"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer "Deactivate Query"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or "Stop Query"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I choose this word because there is no opposite word like "unterminate" in opposite to "Activate/Reactivate" and "Stop". To suggest people that they cannot restart it later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point

[ text "Nakadi SQL API provides a self-serviceable SQL interface for stream processing Nakadi event"
, text " types. By expressing transformations as SQL, this service enables a broader audience to analyse"
, text " and process streaming data in real-time. Nakadi SQL is scalable, elastic and fault-tolerant."
, text " It's planned to support a wide range of streaming operations, including data filtering,"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's -> It is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, but fix it in api.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

, text " types. By expressing transformations as SQL, this service enables a broader audience to analyse"
, text " and process streaming data in real-time. Nakadi SQL is scalable, elastic and fault-tolerant."
, text " It's planned to support a wide range of streaming operations, including data filtering,"
, text " transformations, aggregations, joins, windowing, and sessionization."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sessionization?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither do I :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, newline
, text "The output events are written to an output EventType, which can be accessed via Nakadi."
, newline
, link "More in the API Manual" "https://apis.zalando.net/apis/3d932e38-b9db-42cf-84bb-0898a72895fb/ui"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't accessible for non-Zalandos

Copy link
Contributor Author

@SergKam SergKam Nov 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but

@SergKam SergKam merged commit 39ad08e into master Nov 16, 2018
@SergKam SergKam deleted the nakadi-sql branch November 16, 2018 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants