Add a health check with last time of sync - #204
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 1480
💛 - Coveralls |
Contributor
|
It'll still be healthy before the first |
Member
Author
|
I moved registration of |
Contributor
|
Could you rebase on master? I've fixed the e2e deployment. |
Contributor
|
Otherwise LGTM. |
Member
Author
|
👍 |
1 similar comment
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an extensible health check endpoint as well as an initial check for the last sync time.
The output can be seen at
http://127.0.0.1:7979/healthz?full=1.This particular check starts out unhealthy and switches to healthy for as long as the last sync interval isn't missed for too long (this code sets it to two intervals).
This can be used
readinessProbeto ensure the initial sync succeeds, as well aslivenessProbeto restart stackset-controller in case it gets stuck