Only configure main domain as cluster-domain for legacy clusters #9677
+69
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linki
added
do-not-merge
minor
demonCoder95
force-pushed
the
stackset-eks
branch
from
9f0d633 to
bb52a71
Compare
linki
force-pushed
the
stackset-eks
branch
6 times, most recently
from
cdaf98f to
b2efaed
Compare
linki
changed the title
linki
changed the title
linki
commented
Jul 15, 2025
| @@ -26,6 +25,7 @@ metadata: | |||
| name: "{{{APPLICATION}}}-{{{COMPONENT}}}-config-provider-aws" | |||
| data: | |||
| CLUSTER_PROVIDER: "zalando-aws" | |||
| CLUSTER_DOMAIN_INTERNAL: "teapot-e2e.zalan.do" | |||
There was a problem hiding this comment.
CLUSTER_DOMAIN_INTERNAL is just the name of the variable to give a second cluster domain to stackset-controller. It doesn't actually need to be internal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal discussion revealed that the
cluster-domainargument is merely used to detect/filter Ingress/RouteGroup domains on per-stack resources. The main hostname of the stackset isn't affected by this setting.Since we intend to stop supporting the main hostname variants for individual stacks on EKS clusters, we can just drop it entirely from the list to achieve that.
Users can still use the cluster-internal DNS domain to access individual stacks.