skipper: disable image-updater-bot for main image #8216
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
added
the
minor
image-updater-bot replaces all matching image urls in the manifest so use print template function to disable it for main image. Follow up #8193 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
skipper/update-canary-via-bot-2
branch
from
a1169ca
to
2a19cad
Compare
See example #8205 |
Here is an example when it worked properly because main image url was different from canary |
|
https://github.com/zalando-incubator/kubernetes-on-aws/pull/8220/files advances only canary image, so I guess we can move on like this and find some way to make the description of it more informative. |
|
👍 |
1 similar comment
|
👍 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
image-updater-bot replaces all matching image urls in the manifest so use print template function to disable it for main image.
Follow up #8193