Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipper: increase redis termination grace period #7658

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

AlexanderYastrebov
Copy link
Member

Default termination grace period is 30s and matches a delay added by #5817 which sometimes leads to sporadic FailedPreStopHook events.

Follow up on #5817

@AlexanderYastrebov AlexanderYastrebov added the minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call. label Jun 7, 2024
@szuecs
Copy link
Member

szuecs commented Jun 7, 2024

👍

Default termination grace period is 30s and matches a delay added
by #5817 which sometimes leads to sporadic FailedPreStopHook events.

Follow up on #5817

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@AlexanderYastrebov AlexanderYastrebov force-pushed the skipper/redis-termination-timeout branch from 93e4425 to a60ea4b Compare June 10, 2024 12:39
@mikkeloscar
Copy link
Contributor

👍

1 similar comment
@AlexanderYastrebov
Copy link
Member Author

👍

@AlexanderYastrebov AlexanderYastrebov merged commit de7fef1 into dev Jun 11, 2024
10 checks passed
@AlexanderYastrebov AlexanderYastrebov deleted the skipper/redis-termination-timeout branch June 11, 2024 09:57
This was referenced Jun 11, 2024
This was referenced Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/alpha merged/beta merged/kube-1.30 merged/stable minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants