Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skipper version, step 2/2 #7649

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

RomanZavodskikh
Copy link
Member

Merge #7648 before this one

FYI zalando/skipper@v0.21.101...v0.21.108

Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
@RomanZavodskikh RomanZavodskikh added do-not-merge major Major feature changes or updates, e.g. feature rollout to a new country, new API calls. minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call. dependencies labels Jun 6, 2024
@AlexanderYastrebov
Copy link
Member

Does it target a wrong branch?

Base automatically changed from skipper/update to dev June 7, 2024 09:37
@RomanZavodskikh
Copy link
Member Author

@AlexanderYastrebov

Does it target a wrong branch?

No, it does target the right branch because:

  • this particular PR is simple in every point in time (1 line removed, 1 line added)
  • after merging the corresponding canary PR it is automatically redirected to be merged into dev.

If the PR is created to dev from the very beginning, the UI will show 2 lines added and 2 lines removed even after canary PR merged which could be confusing.

@RomanZavodskikh
Copy link
Member Author

👍

1 similar comment
@AlexanderYastrebov
Copy link
Member

👍

@AlexanderYastrebov AlexanderYastrebov merged commit d8d8a4b into dev Jun 11, 2024
10 checks passed
@AlexanderYastrebov AlexanderYastrebov deleted the skipper/update-main-fleet branch June 11, 2024 09:35
This was referenced Jun 11, 2024
This was referenced Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies major Major feature changes or updates, e.g. feature rollout to a new country, new API calls. merged/alpha merged/beta merged/kube-1.30 merged/stable minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants