Sprite importing scripts #40
Conversation
|
Hey, thanks! Sorry for being late to take a look at this. I agree with JS looking like the best option, and think the abstractions make it easy to skim through and know what's going on. |
| @@ -66,6 +66,9 @@ namespace csight::raid { | |||
|
|
|||
| bool RaidPokemon::GetIsShiny() { return m_shineType > shiny::None; } | |||
|
|
|||
| // TODO: find how to obtain raid pokemon Gigantamax status | |||
| bool RaidPokemon::GetIsGigantamax() { return false; } | |||
There was a problem hiding this comment.
This comes from the raid templates, so they'll need to be added later. I'm not opposed to that being added outside of this PR though.
Ideally the templates are read from the game instead of being hardcoded into csight, but I've been a bit lazy and haven't looked for them.
|
I see the PR is in a draft state at the moment. Let me know when you're ready for a review, and I'll get right on it 🙂 |
|
@ulucs I'm going to close this PR since it appears to be inactive. Please feel free to reopen it or open a new PR if you happen to come back to it. 😄 |
Here are the three versions of importing scripts. I think I can write the js version with a little less abstraction, like ruby. I feel I've gone a bit overboard with abstraction in javascript. Python does not preserve key orders when reading from JSON, so an unbuggy implementation will be painful.
As it stands, I feel the best option is javascript (maybe with less abstraction).