Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements for pan & zoom #302

Merged
merged 15 commits into from
Jul 15, 2019

Conversation

zakandrewking
Copy link
Owner

@zakandrewking zakandrewking commented May 7, 2019

These changes fix a performance issue with tooltips on objects. When many objects have mouseover event listeners, then pan/zoom performance suffers. Therefore, the tooltip behaviors were optimized so this performance hit only occurs when the tooltips are activated over objects, which is not the default setting.

This PR also implements requestAnimationFrame for more predictable performance with pan/zoom.

Also disabled the grabbing cursor which was causing slowdowns

@zakandrewking zakandrewking force-pushed the testing-performance-mobile-pan-zoom branch from 1a5cd46 to 7e317ab Compare July 12, 2019 15:34
@zakandrewking zakandrewking force-pushed the testing-performance-mobile-pan-zoom branch from 7e317ab to e23d1c4 Compare July 12, 2019 18:45
@zakandrewking zakandrewking force-pushed the testing-performance-mobile-pan-zoom branch from e23d1c4 to 1f2c40e Compare July 12, 2019 18:53
@zakandrewking zakandrewking changed the title Testing performance mobile pan zoom Performance improvements for pan & zoom Jul 15, 2019
@zakandrewking zakandrewking marked this pull request as ready for review July 15, 2019 20:50
@zakandrewking zakandrewking merged commit 521bbd3 into master Jul 15, 2019
@zakandrewking zakandrewking deleted the testing-performance-mobile-pan-zoom branch July 15, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant