V1.1.1 #3
Merged
V1.1.1 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed long_description file to be up to date with current README. - Added new version number.
-Fixed bug in class method from_angle() where an angle of zero would produce a quaternion without taking the norm parameter into consideration. -Added comments explaining code. -Formatted doc strings and comments to be restricted to column 72 and less. -Replaced single quote strings with double quote strings. -Changed atan2 to acos for angle property.
-Added comments explaining code. -Formatted doc strings and comments to be restricted to column 72 and less. -Other code formatting.
wikipedia section in the comment. - Added math.degrees() and math.radians() functions for converting angles. - Rewrote parts of from_angle() method to be a bit more robust. - Fixed comment typos. - Rewrote sections for formatting.
- Added unit tests for the from_angle() method and comments explaining them. - Changed some AssertEqual cases to AssertAlmostEqual to work around floating-point imprecision. - Added comments to test_power tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quaternions v1.1.1