Tons of fixes for the codebase #629
Conversation
|
Thanks for the effort you went through here. Unfortunately, it's kind of dependant on a discussion that hasn't been held yet in #624, so I'll also refrain from reviewing the changes until we've had at least some form of discussion across the people with repo access (or I've lost patience for some reason or another). From the commit messages, many of these look promising, however. |
|
That's completely alright. I just happened to pick a FOSS project I use and direct my hypomanic energy into it. I'll keep an eye on the discussion. I'm sure we can drop some commits and edit others to fit in with what is discussed eventually. |
|
I'll take a look. I appreciate your work and I fully agree with adhering to PEP, maybe excepting line widths. |
|
Also, aside from the change I commented on, these are good changes and I'd like to merge them. If you could rebase on |
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Block comment should start with '# ' Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Test for membership should be 'not in' Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Expected 2 blank lines, found 1 Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Missing whitespace after , Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
At least 2 spaces before inline comment Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Do not use variables named 'I', 'O', or 'l' Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Module level import not at top of file Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Multiple imports on one line Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Indentation is not a multiple of 4 Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Do not use bare except A bare except: clause will catch SystemExit and KeyboardInterrupt exceptions, making it harder to interrupt a program with Control-C, and can disguise other problems. Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Expected 2 blank lines after end of function or class Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Multiple spaces before operator Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Missing whitespace around operator Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Invalid escape sequence Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
|
Reverted the chain comparisons lines, and rebased on |
|
Thank you! |
|
Thank you for your work! |
This PR fixes typos, some logical warnings/errors, PEP8 coding style violations, resolves some unresolved imports and errors around incorrect module imports, adjusts exceptions so they don't catch
Ctrl+Cetc, lints markdown, and a bit more.I would like to follow
PEP8: E501so lines are not longer than 120 chars, and apply PEP8 naming conventions so variable names, argument names, function names, and class names are pythonic and consistent. Let me know if I should go ahead and do these.There are a few instances of
import Image. I'm not sure what module/package that belongs to, and I'd like clarification as to what it actually imports. Additionally, I would like to push arequirements.txt. Let me know if that's okay.When reviewing, please do so by commit lest the changes look like spaghetti.