Skip to content

ci: stop cancelling required-check runs on pull request edits - #600

Merged
ss-o merged 1 commit into
nextfrom
bug-597-required-check-cancel
Oct 8, 2026
Merged

ss-o merged 1 commit into
nextfrom
bug-597-required-check-cancel

Conversation

@ss-o

@ss-o ss-o commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Description

Commit Lint and Public Contract Impact run on edited (and label events) as well as synchronize. A push and a pull-request edit landing together started two runs for one head SHA, and the shared concurrency group cancelled one of them. The cancelled check runs for required contexts kept #594 BLOCKED while the same contexts had passed; re-running the two cancelled runs made it CLEAN.

This removes the concurrency group from both workflows, with a comment saying why, so every run finishes. Both finish in seconds, so a superseded run costs almost nothing. Any group would still cancel a same-SHA run: a running one with cancel-in-progress: true, a pending one without it. The edited and label triggers stay, because Validate PR Title, Validate Issue Link and the contract label policy depend on them.

This is a deliberate exception to the organization workflow contract's concurrency rule (section 3) for these two required, sub-minute workflows. The organization's reusable commit-lint has the same trigger and group shape.

Related issues

Closes #597

Type of change

  • ci - CI/workflow change

Checklist

  • Ordinary work targets next; only same-repository hotfixes target main
  • A next to main promotion uses a merge commit and records both parent SHAs (not a promotion)
  • Commit messages follow Conventional Commits format
  • Any Co-authored-by trailer credits a real human, never a bot, AI agent, or automation
  • I have read the contribution guidelines
  • Existing tests pass (zsh -n zi.zsh / Trunk checks)
  • Documentation updated if needed (no documentation describes these groups)

Local checks: actionlint on both files, trunk check on both files, zsh -f tests/ci-registration.zsh, zsh tests/public-contract-impact.zsh.

@ss-o ss-o changed the title fix(ci): stop cancelling required-check runs on pull request edits ci: stop cancelling required-check runs on pull request edits Oct 8, 2026
@ss-o
ss-o force-pushed the bug-597-required-check-cancel branch from 016deb1 to 754887f Compare October 8, 2026 00:18
@ss-o
ss-o force-pushed the bug-597-required-check-cancel branch from 754887f to b4dba3c Compare October 8, 2026 00:28
Commit Lint and Public Contract Impact run on edited (and label) events
as well as synchronize. A push plus a pull-request edit started two runs
for one head SHA and the shared concurrency group cancelled one. The
cancelled check runs for required contexts kept #594 blocked while the
same contexts had passed.

Both workflows finish in seconds, so drop their concurrency groups and
let every run finish instead of producing cancelled required checks.

Closes #597
@ss-o
ss-o force-pushed the bug-597-required-check-cancel branch from b4dba3c to 4562f9f Compare October 8, 2026 00:50

@ss-o ss-o left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallback review under ADR-0026: Copilot request not registered on 4562f9f

Findings

No blocking findings on this head.

  • Removing the concurrency groups from commit-lint.yml and public-contract-impact.yml is correct for the failure in #597. Any group, with or without cancel-in-progress, can cancel a same-SHA run, and those cancelled required contexts blocked #594. The comment says so and stays accurate.
  • Every check in both workflows still comes from the event payload and git; nothing depended on the group. The edited and label triggers stay, which Validate PR Title, Validate Issue Link and the contract label policy need.
  • Untested assumption: with two finished runs on one SHA, GitHub uses the newest check run for each name, so a stale run (for example one validating the title before an edit) should not decide the merge state. Not observed on GitHub yet.
  • This is a deliberate exception to section 3 of the organization workflow contract, recorded in the PR description.

Checks this rests on

actionlint and trunk check on both files; zsh -f tests/ci-registration.zsh; zsh tests/public-contract-impact.zsh; GitHub checks on this head.

@ss-o
ss-o merged commit 43f6e93 into next Oct 8, 2026
139 checks passed
@ss-o
ss-o deleted the bug-597-required-check-cancel branch October 8, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant