Repository navigation
ci: re-pin zi-install from z-shell/agent-skills (z-shell/.github#741) - #233
Merged
Merged
Conversation
The skill moved to z-shell/agent-skills and is now user-invoked. The Org Routing caller moves to z-shell/.github 502ec614, whose approved record names the new source, and the installer contract's external consumer entry follows the skill, with contract_version bumped to 4 for the consumer removal. Signed-off-by: Sal <59910950+ss-o@users.noreply.github.com>
Deploying src with
|
| Latest commit: |
045ab7a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c3570e2c.zi-src.pages.dev |
| Branch Preview URL: | https://feature-741-repin-skills.zi-src.pages.dev |
ss-o
commented
Oct 7, 2026
ss-o
left a comment
Member
Author
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on 045ab7a
Findings
No actionable findings.
Scope: The complete diff against main (9bc3476): the reinstalled zi-install skill and its agents/openai.yaml, the Org Routing caller pin, the regenerated routing block, the Trunk exclusion, the installer contract entry and version, and one test assertion.
Note
This is a maintainer-elected self-review, not an independent review or approval to merge.
Validation
- Passed: all 15 checks on this head, including
Org Routing / Org Routingat 502ec614 andInstaller contract impactwith the acknowledgement marker.Installer consumer evidenceis skipped on pull requests by design. - Local:
org-routing.py checkcurrent; the impact detector exits 0 with this body; detector tests 7 ok;tests/installers.shpasses; trunk clean. - Known pre-existing failure: the push-only evidence audit still reports
z-shell/zi/README.mdas stale, as it already does onmain. This change clears the other stale pin it reports there.
Checklist verdicts and supporting evidence
- Re-pin pairing: pass. Skill reinstall, caller pin and routing block move together, as
runbooks/org-review.mdrequires; the previous localSKILL.mdmatched the old approved digest before--force. - Contract: pass. Only the consumer's repository, path and evidence change; its scope and surfaces are identical, and the version bump is what the detector's breaking-gate policy requires for a consumer removal.
- Formatter safety: pass.
.github/skills/zi-install/**joins the existing Prettier and markdownlint exclusion, so the pre-commit formatter cannot change the pinned bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-pins the vendored
zi-installskill to its new home in z-shell/agent-skills (z-shell/.github#741, ADR-0037). It follows the re-pin pairing in z-shell/.githubrunbooks/org-review.md..github/skills/zi-install/: reinstalled withgh skill install z-shell/agent-skills plugins/z-shell/skills/zi-install --pin 01aa715a… --dir .github/skills --force. The body is unchanged. The skill is now user-invoked:disable-model-invocation: trueinSKILL.md, plus a newagents/openai.yamlwithallow_implicit_invocation: false. Before--force, the localSKILL.mdmatched the previously approved digest exactly, so nothing local was overwritten..github/workflows/org-routing.yml: the caller moves froma07ed57cto502ec614, current z-shell/.githubmain. Its approved record names the agent-skills revision (feat(agents): approve zi-install from agent-skills (#741) .github#759) and keepscode-reviewatede9ed98from ci: re-pin the code-review skill with bundled criteria #232.AGENTS.md: routing block regenerated withorg-routing.py apply; the entry now reads "skill fromz-shell/agent-skillsvendored at approved revision01aa715a124a"..trunk/trunk.yaml: the Prettier and markdownlint exclusion now covers.github/skills/zi-install/**as well, so the formatter cannot rewrite the pinned files.contracts/installer-contract-v1.json: the external consumer moves fromz-shell/.github:.github/skills/zi-install/SKILL.mdtoz-shell/agent-skills:plugins/z-shell/skills/zi-install/SKILL.md, with published evidence at01aa715a. The surfaces are unchanged.contract_versiongoes from 3 to 4, because the detector's policy treats removing a consumer as breaking.tests/installer-contract-impact.zsh: the pending-evidence assertion names the new consumer path.[installer-impact:z-shell/.github:.github/skills/zi-install/SKILL.md] updated here: the skill moved to z-shell/agent-skills; its new consumer entry is added in this PR
Refs z-shell/.github#741.
Verification
org-routing.py check --repository z-shell/srcwith z-shell/.github tooling at502ec614: current.installer-contract-impact.zsh --base origin/main --head HEADwith this PR body: exit 0. It reportsconsumer-removal(breaking, acknowledged) andconsumer-addition(informational).tests/installer-contract-impact.zsh: 7 ok.sh ./tests/installers.sh: pass.trunk check: no issues.installer-contract-evidence.zsh: the agent-skills consumer iscurrent. The audit still exits 1 forz-shell/zi/README.md, whose pin was already stale onmain. That push-only audit fails onmaintoday for both that pin and the old z-shell/.github one, and this PR clears the latter.Agent handoff
.github/skills/zi-installfrom z-shell/.github; refresh the stalez-shell/zi/README.mdevidence pin as a separate change.