Repository navigation
fix(tests): wait for routing fixture maintenance - #800
Merged
Merged
Conversation
ss-o
commented
Oct 15, 2026
ss-o
left a comment
Member
Author
There was a problem hiding this comment.
Fallback review under ADR-0026: maintainer elected, no Copilot request on 473b325
No actionable findings.
- Correctness: fixture Git commands pass both foreground-maintenance controls. Git waits for the housekeeping process tree before the helper returns, avoiding concurrent writes during temporary-directory cleanup. The settings apply to each command and are not persisted.
- Regression: the native test forces loose-object packing with detachment enabled in the fixture configuration. It checks that no detach event occurs and that packing has completed. The previous helper failed with the detach assertion and matching cleanup error; the repaired helper passes.
- Verification: 105 related tests pass on Python 3.14 and 3.10.8, as do 180 forced-maintenance repetitions. All 11 hosted checks pass on this head. Trunk reports no new issues; two inherited Bandit findings remain. Inventory, whitespace and source-signature checks pass.
- Scope and documentation: only the fixture helper and its regression change. Formatting landed separately in #799. Product behavior, persisted settings and published policy are unaffected.
- Limits: this is self-review. The native reproduction used Git 2.56. The exact writer in historical CI failures was not captured. Visual Markdown rendering was not inspected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixture commits can leave detached Git maintenance writing into a temporary repository while Python removes it, producing
Directory not emptyduring test cleanup. Keep automatic maintenance in the foreground for commands issued by the Org Routing test helper, using both the current setting and its garbage-collection fallback.Add a native Git regression that forces loose-object packing, rejects a detach event, and verifies that a pack exists before the helper returns. The controls apply only to fixture commands and do not change repository or global settings.
Refs #796; follow-up to the fixture cleanup failure seen during #797. Formatting was separated into #799.
Verification
Git documents the foreground and detached behavior in its maintenance configuration.
Agent handoff
The reproduced cleanup race is addressed. The exact writer in earlier hosted failures was not captured, so their historical cause remains unconfirmed. This changes test infrastructure only.