RANGER-855 - Fix "BooleanInstantiation" issues

Signed-off-by: Alok Lal <alok@apache.org>
yzhou2001 · Mar 25, 2016 · e156625 · e156625
1 parent 9a424ce
commit e156625
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/dev-support/ranger-pmd-ruleset.xml b/dev-support/ranger-pmd-ruleset.xml
@@ -28,7 +28,6 @@
 	<exclude name="AvoidBranchingStatementAsLastInLoop" />
 	<exclude name="AvoidThreadGroup" />
 	<exclude name="AvoidUsingHardCodedIP" />
-	<exclude name="BooleanInstantiation" />
 	<exclude name="ClassCastExceptionWithToArray" />
 	<exclude name="CollapsibleIfStatements" />
 	<exclude name="DoubleCheckedLocking" />

diff --git a/security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java b/security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java
@@ -368,7 +368,7 @@ public Boolean parseBoolean(String value, String errorMessage,
 			if (stringUtil.isEmpty(value)) {
 				return null;
 			} else {
-				return new Boolean(value.trim());
+				return Boolean.valueOf(value.trim());
 			}
 		} catch (Throwable t) {
 			throw createRESTException(errorMessage, messageEnum, objectId,

diff --git a/...main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java b/...main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java
@@ -131,7 +131,7 @@ public void doFilter(ServletRequest request, ServletResponse response,
 				if (userSession != null) {
 
 					Object ssoEnabledObj = request.getAttribute("ssoEnabled");
-					Boolean ssoEnabled = ssoEnabledObj != null ? new Boolean(String.valueOf(ssoEnabledObj)) : PropertiesUtil.getBooleanProperty("ranger.sso.enabled", false);
+					Boolean ssoEnabled = ssoEnabledObj != null ? Boolean.valueOf(String.valueOf(ssoEnabledObj)) : PropertiesUtil.getBooleanProperty("ranger.sso.enabled", false);
 					userSession.setSSOEnabled(ssoEnabled);
 
 					if (userSession.getClientTimeOffsetInMinute() == 0) {

diff --git a/security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java b/security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java
@@ -571,6 +571,6 @@ public void syncResponseWithJsonRequest() {
 		this.setResourceName(null);		
 		this.setRepositoryType(null);		
 		this.setVersion(null);
-		this.setIsRecursive(new Boolean(null));
+		this.setIsRecursive(Boolean.FALSE);
 	}
 }