SRV backend IPv6 support #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extract AAAAs from additional data * Query for AAAAs if not present and we don't find an A
erincandescent
commented
Jun 15, 2019
| case *dns.A: | ||
| hosts[record.Header().Name] = record.A.String() | ||
| case *dns.AAAA: | ||
| hosts[record.Header().Name] = fmt.Sprintf("[%s]", record.AAAA.String()) |
There was a problem hiding this comment.
This is slightly annoying - Gobetween uses net.Dial("tcp", addr) which requires bracketed IPv6s. If storing IPs here, it would be better to store them as net.IPs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current backend SRV only looks for A records / IPv4 addresses. I wish to use gobetween as the L4 ingress on a Kubernetes cluster where the internal network is IPv6 only
This change: