fix: memoization issue in SplitPane component#17
Open
Omriruvio wants to merge 1 commit intoyyllff:mainfrom
Open
fix: memoization issue in SplitPane component#17Omriruvio wants to merge 1 commit intoyyllff:mainfrom
Omriruvio wants to merge 1 commit intoyyllff:mainfrom
Conversation
This commit fixes an issue with the `useMemo` hook in the `SplitPane` component, which was causing a warning about the size of the memoized array changing between renders. The issue was caused by variables that were not memoized and were changing on each render. To fix the issue, we memoized the variables that were causing the issue using the `useMemo` hook, including `children`, `propSizes`, and `wrapSize`. This ensures that these variables are not recreated on each render, preventing the warning about the size of the memoized array changing. Additional minor type corrections were made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue with the
useMemohook in theSplitPanecomponent, which was causing a warning about the size of the memoized array changing between renders. The issue was caused by variables that were not memoized and were changing on each render.To fix the issue, we memoized the variables that were causing the issue using the
useMemohook, includingchildren,propSizes, andwrapSize. This ensures that these variables are not recreated on each render, preventing the warning about the size of the memoized array changing.Additional minor type corrections were made.