Remove #children fron BaseEvent
#90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`#children` has been deprecated as of Rails 7.2. rails/rails#43390 Unlike Rails, I decided to remove `#children` from `BaseEvent` since it'd be a techdebt to keep this method in the future, and I guess this method would not be used very well. By the way, I found this deprecation on Rails when I'm about to add the support for `deprecation.rails` on #89. I hope this won't cause problems for users who use this gem.
yykamei
changed the title
#children fron BaseEvent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#childrenhas been deprecated as of Rails 7.2.rails/rails#43390
Unlike Rails, I decided to remove
#childrenfromBaseEventsince it'd be a techdebt to keep this method in the future,
and I guess this method would not be used very well.
By the way, I found this deprecation on Rails when I'm about to
add the support for
deprecation.railson #89. I hope this won't causeproblems for users who use this gem.