Skip to content

Commit

Permalink
Ignore more non-critical IO error in BlockCacheLookupForReadAheadSize…
Browse files Browse the repository at this point in the history
…() in crash test (facebook#12822)

Summary:
**Context/Summary:**
Similar to facebook#12814 (comment)

Pull Request resolved: facebook#12822

Test Plan: CI

Reviewed By: jaykorean

Differential Revision: D59166188

Pulled By: hx235

fbshipit-source-id: 68c2eb7b319103ede0ba34944a0737440aecb17f
  • Loading branch information
hx235 authored and facebook-github-bot committed Jun 28, 2024
1 parent 5bb7f95 commit 0b10e7d
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions table/block_based/block_based_table_iterator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -823,6 +823,12 @@ void BlockBasedTableIterator::BlockCacheLookupForReadAheadSize(
read_options_, block_handle,
&(block_handle_info.cachable_entry_).As<Block_kData>());
if (!s.ok()) {
#ifndef NDEBUG
// To allow fault injection verification to pass since non-okay status in
// `BlockCacheLookupForReadAheadSize()` won't fail the read but to have
// less or no readahead
IGNORE_STATUS_IF_ERROR(s);
#endif
break;
}

Expand Down Expand Up @@ -853,6 +859,9 @@ void BlockBasedTableIterator::BlockCacheLookupForReadAheadSize(
}

#ifndef NDEBUG
// To allow fault injection verification to pass since non-okay status in
// `BlockCacheLookupForReadAheadSize()` won't fail the read but to have less
// or no readahead
if (!index_iter_->status().ok()) {
IGNORE_STATUS_IF_ERROR(index_iter_->status());
}
Expand Down

0 comments on commit 0b10e7d

Please sign in to comment.