Fix for #484: module 'plistlib' has no attribute 'readPlist' (#485)

* Fix for #484: module 'plistlib' has no attribute 'readPlist' Pythonista 3 was recently upgraded to python3.10. This fix mirigates plist.py:8: DeprecationWarning: The readPlist function is deprecated, use load() instead pl=plistlib.readPlist(fileName) * Typo fix * isAlive( * Fix whitespace --------- Co-authored-by: Christian Clauss <cclauss@me.com>
ywangd · May 4, 2023 · 089d591 · 089d591
1 parent 9f55ca4
commit 089d591
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/system/shcommon.py b/system/shcommon.py
@@ -17,7 +17,8 @@
 if IN_PYTHONISTA:
     import plistlib
 
-    _properties = plistlib.readPlist(os.path.join(os.path.dirname(sys.executable), 'Info.plist'))
+    with open(os.path.join(os.path.dirname(sys.executable), 'Info.plist'), 'rb') as fp:
+        _properties = plistlib.loads(fp.read())
     PYTHONISTA_VERSION = _properties['CFBundleShortVersionString']
     PYTHONISTA_VERSION_LONG = _properties['CFBundleVersion']
 

diff --git a/system/shui/pythonista_ui.py b/system/shui/pythonista_ui.py
@@ -894,7 +894,7 @@ def render(self, no_wait=False):
                 self.render_thread.cancel()
             self._render()
         else:  # delayed rendering
-            if self.render_thread is None or not self.render_thread.isAlive():
+            if self.render_thread is None or not self.render_thread.is_alive():
                 self.render_thread = sh_delay(self._render, self.RENDER_INTERVAL)
             # Do nothing if there is already a delayed rendering thread waiting