This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Use conda-forge/websockify, use environment.yml in Dockerfile #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvipanda
reviewed
Jul 27, 2020
|
This is awesome, thank you :) One comment, otherwise great to merge. |
|
Awesome, thanks @manics! |
yuvipanda
pushed a commit
that referenced
this pull request
Jan 17, 2023
Add installation instructions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
websockify was accepted into conda-forge 🙂 conda-forge/staged-recipes#12168
This PR also reduces duplication by copying
environment.ymlinto theDockerfile