Check for lints with ruff

.github/workflows/build.yml

@@ -18,5 +18,7 @@ jobs:
           uses: abatilo/actions-poetry@v2
         - name: Poetry install
           run: poetry install
-        - name: Run build
+        - name: Run unit tests
           run: poetry run pytest
+        - name: Check for lints
+          run: poetry run ruff check

pyproject.toml

@@ -11,6 +11,7 @@ python = "^3.8"
 
 [tool.poetry.group.dev.dependencies]
 pytest = "^8.2.1"
+ruff = "^0.4.4"
 
 [build-system]
 requires = ["poetry-core"]

tests/test_parse.py

@@ -3,7 +3,7 @@
 from datetime import datetime
 from os import walk
 from os.path import join
-from viewstate import *
+from viewstate import ViewState, ViewStateException
 
 
 class TestParse(object):

tests/test_viewstate.py

@@ -2,7 +2,7 @@
 
 from os import walk
 from os.path import join
-from viewstate import *
+from viewstate import ViewState, ViewStateException
 
 
 class TestViewState(object):
@@ -19,7 +19,7 @@ def test_is_valid(self):
 
     def test_invalid_base64(self):
         with pytest.raises(ViewStateException):
-            vs = ViewState("hello")
+            ViewState("hello")
 
     def test_invalid_decode(self):
         with pytest.raises(ViewStateException):

viewstate/__init__.py

@@ -1,2 +1,5 @@
 from .viewstate import ViewState
 from .exceptions import ViewStateException
+
+
+__all__ = [ViewState, ViewStateException]

viewstate/parse.py

@@ -181,14 +181,14 @@ class StringArray(Parser):
     @staticmethod
     def parse(b):
         n, remain = Integer.parse(b)
-        l = []
+        lst = []
         for _ in range(n):
             if not remain[0]:
                 val, remain = "", remain[1:]
             else:
                 val, remain = String.parse(remain)
-            l.append(val)
-        return l, remain
+            lst.append(val)
+        return lst, remain
 
 
 class Array(Parser):
@@ -197,11 +197,11 @@ class Array(Parser):
     @staticmethod
     def parse(b):
         n, remain = Integer.parse(b)
-        l = []
+        lst = []
         for _ in range(n):
             val, remain = Parser.parse(remain)
-            l.append(val)
-        return l, remain
+            lst.append(val)
+        return lst, remain
 
 
 class StringRef(Parser):
@@ -231,12 +231,12 @@ def parse(b):
         type, remain = Parser.parse(b)
         length, remain = Integer.parse(remain)
         n, remain = Integer.parse(remain)
-        l = [None] * length
+        lst = [None] * length
         for _ in range(n):
             idx, remain = Integer.parse(remain)
             val, remain = Parser.parse(remain)
-            l[idx] = val
-        return l, remain
+            lst[idx] = val
+        return lst, remain
 
 
 class Dict(Parser):
@@ -261,11 +261,11 @@ class TypedArray(Parser):
     def parse(b):
         typeval, remain = Parser.parse(b)
         n, remain = Integer.parse(remain)
-        l = []
+        lst = []
         for _ in range(n):
             val, remain = Parser.parse(remain)
-            l.append(val)
-        return l, remain
+            lst.append(val)
+        return lst, remain
 
 
 class BinaryFormatted(Parser):

viewstate/viewstate.py

@@ -1,4 +1,4 @@
-from base64 import b64decode, b64encode
+from base64 import b64decode
 from binascii import Error as BinAsciiError
 
 from .exceptions import ViewStateException
@@ -11,7 +11,7 @@ def __init__(self, base64=None, raw=None):
             self.base64 = base64
             try:
                 self.raw = b64decode(self.base64)
-            except BinAsciiError as bae:
+            except BinAsciiError:
                 raise ViewStateException("Cannot decode base64 input")
         elif raw:
             self.raw = raw