refactor: consolidate utility functions and add comprehensive main.go tests #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsive tests - Move SetRLimitNoFile and getAddrsFromFile functions from utils.go to main.go - Remove utils.go file to simplify project structure - Add main_test.go with comprehensive test coverage: - TestSetRLimitNoFile: Tests file descriptor limit setting with proper cleanup - TestValidateClientFlags: Tests flag validation logic for various scenarios - TestGetAddrsFromFile: Tests address file parsing with edge cases - TestGetAddrsFromFileNotFound: Tests error handling for missing files - All tests pass with race detection enabled 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SetRLimitNoFileandgetAddrsFromFilefrom utils.go into main.goTest plan
TestSetRLimitNoFile: Tests file descriptor limit setting with proper state restorationTestValidateClientFlags: Tests flag validation logic for multiple scenarios (valid/invalid combinations)TestGetAddrsFromFile: Tests address file parsing including edge cases (empty files, whitespace, newlines)TestGetAddrsFromFileNotFound: Tests error handling for non-existent filesgo test -race)🤖 Generated with Claude Code