Skip to content

fix(treesitter): add pcall guard to prevent crash#3807

Open
IoannisKouimoutzoglou wants to merge 1 commit intoyutkat:mainfrom
IoannisKouimoutzoglou:main
Open

fix(treesitter): add pcall guard to prevent crash#3807
IoannisKouimoutzoglou wants to merge 1 commit intoyutkat:mainfrom
IoannisKouimoutzoglou:main

Conversation

@IoannisKouimoutzoglou
Copy link
Contributor

Added a pcall check to the Treesitter config. This prevents Neovim from failing to load the rest of the configuration if the nvim-treesitter module isn't installed or available yet.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the Neovim configuration by introducing a protective measure for the nvim-treesitter plugin. It ensures that the editor's startup process remains stable and functional, even if the Treesitter module is missing or encounters an issue, thereby preventing critical configuration failures and improving the user experience.

Highlights

  • Error Handling: Implemented a pcall guard around the nvim-treesitter.configs require call to prevent Neovim from crashing if the plugin is not found or fails to load.
  • User Feedback: Added a vim.api.nvim_echo message to inform the user if the nvim-treesitter module is not available, providing clear feedback instead of a silent failure.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .config/nvim/lua/rc/pluginconfig/nvim-treesitter.lua
    • Wrapped the require("nvim-treesitter.configs") call in a pcall to safely attempt loading the module.
    • Added a conditional check to verify if the nvim-treesitter module was successfully loaded.
    • Included an nvim_echo message to display a warning if Treesitter is not found.
    • Modified the setup call to use the safely loaded nvim-treesitter.configs table.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a pcall guard to the Treesitter configuration to prevent Neovim from crashing if the module is not available. This is a good defensive measure. I've added a couple of comments regarding code formatting to improve readability and maintain consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant